Replies: 6 comments
-
Hello, 'Marv51! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future! |
Beta Was this translation helpful? Give feedback.
-
Thanks, @Marv51 for the initiative! @michael-hawker what do you think about more explicitly describing the fields? |
Beta Was this translation helpful? Give feedback.
-
Thanks for the issue @Marv51, FocusTracker is a pretty naïve helper at the moment just calling to ask about what has focus. If you think there can be some light-heuristics to add on top of it, feel free to continue the discussion here with suggestions. I'm not sure how the window focus stuff will work with WinUI 3 in the future, so I'd just want to make sure we're thinking ahead with any extra logic we add to the control. FYI @azchohfi |
Beta Was this translation helpful? Give feedback.
-
There is no difference in the APIs being used for UWP vs WinUI3 in this control. It is all just events that the Xaml framework automatically fires. The biggest difference was that in the past, before XamlRoot, we used the FocusManager.GetFocusedElement() method, and now we use the XamlRoot version, but that was/is already the case if the UWP APIs reports that there is a XamlRoot. Any change here would just work for WinUI3, so I'm not worried. |
Beta Was this translation helpful? Give feedback.
-
@azchohfi I was thinking more for the focus of the application itself as @Marv51 calls out as a potential improvement, like |
Beta Was this translation helpful? Give feedback.
-
@Marv51 is this something you still wanted to try and contribute to the Toolkit? If so, feel free to check out our wiki with intro on getting started with contributions, and let us know if you run into troubles. Thanks! |
Beta Was this translation helpful? Give feedback.
-
Describe the problem this feature would solve
Focus in UWP/WinUI is a not exactly trivial problem, I guess that's why FocusTracker was added in the first place.
This is what the FocusTracker looks like if the RootScrollViewer has focus:
It is hard to understand what is going on in this case, because this ScrollViewer is not visible and not added by the users XAML.
In the case that the window is unfocused or the FocusTracker is not active the four fields are simply empty. It would be better to add some information describing why no information is displayed.
Describe the solution
Different solutions for these common focus cases are possible.
Ideas:
If this is a feature that would be interesting for the toolkit, I could try to implement this.
Beta Was this translation helpful? Give feedback.
All reactions