-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional CLI query commands for the ratelimit
module
#241
base: master
Are you sure you want to change the base?
Conversation
…d by the module to enhance clarity
…ing error with grpc error
I'm currently stuck while adding the final test cases for In the @vuong177 @GNaD13 @anhductn2001 Could you lend me a hand with this when you have a moment? I'd appreciate your insights into why this might be happening. You can refer to this test case TestChanOpenInit() that i am debugging with. I will give an update if i find any. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jaybxyz , I have some comment. Could you check that pls?
func (s *KeeperTestSuite) TestChanOpenInit() { | ||
// Create client and connections on both chains | ||
path := ibctesting.NewPath(s.chainA, s.chainB) | ||
s.coordinator.SetupConnections(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this current path
doesn't set portID which is used to retrieve capability. In our app.go
, we didn't add port mock
like ibc-go
app.go
. This port is only using for testing, not in product.
Description
This PR resolves #240
Tasks
types/msgs.go
msgServer
andqueryServer
to enhance clarifyMakefile