Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgGrid.fsproj file reference package files from inside demo. Is this correct? #15

Open
martinbryant opened this issue Dec 22, 2023 · 2 comments

Comments

@martinbryant
Copy link
Contributor

https://github.com/CompositionalIT/feliz-ag-grid/blob/main/src/Feliz.AgGrid.fsproj#L20-L25

@isaacabraham
Copy link
Member

This doesn't feel right - I would prefer to duplicate them directly into the main package project.

@mattgallagher92
Copy link
Member

I agree. At a glance I'm not even sure that they're necessary. Could probably just be removed from the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants