Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static client fails on register if name uses '<' '>' characters. #343

Open
thetoster opened this issue Feb 21, 2017 · 3 comments
Open

Static client fails on register if name uses '<' '>' characters. #343

thetoster opened this issue Feb 21, 2017 · 3 comments

Comments

@thetoster
Copy link
Contributor

thetoster commented Feb 21, 2017

Tried on contiki platform. If I set name to through AwaStaticClient_SetEndPointName then from contiki logs you get info about registered but calling awa-serverr-list-clients returns empty list. Removing '<', '>' characters make removes problem.

Checked on version 0.2.5

@boyvinall
Copy link
Contributor

I'm guessing this might be more related to the IPC call for awa-server-list-clients than to the actual registration - did you test this against the deviceserver?

@DavidAntliff
Copy link
Collaborator

I suspect this is almost certainly due to using XML over IPC. The initial expectation was that endpoint names would only contain characters that can be specified in a CoAP URL (since it is used as a bootstrap parameter) however I don't think this is enforced. The endpoint name should be encoded/decoded over IPC to avoid reserved XML characters, and also encoded appropriately when used in the bootstrap URL.

@thetoster
Copy link
Contributor Author

@boyvinall I didn't check with DS. No time to dig around this.
@DavidAntliff I think you are right, when I tried to do awa-server-list-clients -o it crashes with some errors and NULLs. However I didn't copy those logs.
I believe method AwaStaticClient_SetEndPointName should return some error if invalid name is passed, or it do some silent strip off wrong characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants