Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pry-rescue/minitest stops on Minitest::Skip exceptions #65

Open
chrisnicola opened this issue Apr 9, 2014 · 6 comments
Open

pry-rescue/minitest stops on Minitest::Skip exceptions #65

chrisnicola opened this issue Apr 9, 2014 · 6 comments

Comments

@chrisnicola
Copy link

Would make sense to ignore these. Not sure if there is a way to do that.

@schwern
Copy link

schwern commented Apr 18, 2015

👍

1 similar comment
@ericboehs
Copy link

👍

@ryangrush
Copy link

Was anyone ever able to find a solution for ignoring skip?

@chrisnicola
Copy link
Author

Monkey patching is your best bet unfortunately.

@jjercx
Copy link

jjercx commented Oct 28, 2020

@chrisnicola what should we monkey patch?

@singpolyma
Copy link

This works for me:

	module Minitest
		class Test
			alias_method :old_capture_exceptions, :capture_exceptions
			def capture_exceptions
				old_capture_exceptions do
					begin
						yield
					rescue Minitest::Skip => e
						self.failures << e
					end
				end
			end
		end
	end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants