Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pysha3, which is EOL, is listed as a requirement, but doesn't appear to be used. #19

Open
jMyles opened this issue Aug 20, 2023 · 2 comments

Comments

@jMyles
Copy link

jMyles commented Aug 20, 2023

Hey friends. How are y'all?

So, pysha3==1.0.2 is listed as a dependency in the requirements file. As you can see, this project is EOL and no longer supported: https://github.com/tiran/pysha3.

I forked this repo with a mind toward using hashlib or eth_utils instead of pysha3, but it appears that... that's already the case?

A brief foray into the history hasn't illuminated where pysha3 was used - maybe somebody who is more familiar with the dependencies can chime in?

Here's a simple commit updating a couple of dependencies and yanking pysha3, and the tests still pass: #20

@BoboTiG
Copy link

BoboTiG commented Jan 11, 2024

You can use the drop-in replacement module that fixes that issue: https://github.com/BoboTiG/py-eip712-structs-ng

@jMyles
Copy link
Author

jMyles commented Jan 12, 2024

Thanks @BoboTiG :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants