From c3a70ce287ad2fe9f2f4e5ebb1b6e0fffb5ce466 Mon Sep 17 00:00:00 2001 From: Thomas Piellard Date: Thu, 19 Sep 2024 15:12:27 +0200 Subject: [PATCH] feat: used bufMaxSizePolynomials[:len(polynomials[i])] --- ecc/bls12-377/shplonk/shplonk.go | 4 ++-- ecc/bls12-378/shplonk/shplonk.go | 4 ++-- ecc/bls12-381/shplonk/shplonk.go | 4 ++-- ecc/bls24-315/shplonk/shplonk.go | 4 ++-- ecc/bls24-317/shplonk/shplonk.go | 4 ++-- ecc/bn254/shplonk/shplonk.go | 4 ++-- ecc/bw6-633/shplonk/shplonk.go | 4 ++-- ecc/bw6-756/shplonk/shplonk.go | 4 ++-- ecc/bw6-761/shplonk/shplonk.go | 4 ++-- internal/generator/shplonk/template/shplonk.go.tmpl | 2 +- 10 files changed, 19 insertions(+), 19 deletions(-) diff --git a/ecc/bls12-377/shplonk/shplonk.go b/ecc/bls12-377/shplonk/shplonk.go index 55619bac3..197d994c3 100644 --- a/ecc/bls12-377/shplonk/shplonk.go +++ b/ecc/bls12-377/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bls12-378/shplonk/shplonk.go b/ecc/bls12-378/shplonk/shplonk.go index 7eadfcad1..afcdbcfe9 100644 --- a/ecc/bls12-378/shplonk/shplonk.go +++ b/ecc/bls12-378/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bls12-381/shplonk/shplonk.go b/ecc/bls12-381/shplonk/shplonk.go index a9c2c4431..21f226daf 100644 --- a/ecc/bls12-381/shplonk/shplonk.go +++ b/ecc/bls12-381/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bls24-315/shplonk/shplonk.go b/ecc/bls24-315/shplonk/shplonk.go index 038a0800e..4c439a813 100644 --- a/ecc/bls24-315/shplonk/shplonk.go +++ b/ecc/bls24-315/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bls24-317/shplonk/shplonk.go b/ecc/bls24-317/shplonk/shplonk.go index 2b6c0c553..b8a979536 100644 --- a/ecc/bls24-317/shplonk/shplonk.go +++ b/ecc/bls24-317/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bn254/shplonk/shplonk.go b/ecc/bn254/shplonk/shplonk.go index 5e9c6d539..98db94c5a 100644 --- a/ecc/bn254/shplonk/shplonk.go +++ b/ecc/bn254/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bw6-633/shplonk/shplonk.go b/ecc/bw6-633/shplonk/shplonk.go index c901548d0..c2962f210 100644 --- a/ecc/bw6-633/shplonk/shplonk.go +++ b/ecc/bw6-633/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bw6-756/shplonk/shplonk.go b/ecc/bw6-756/shplonk/shplonk.go index eea8739b0..5864904a4 100644 --- a/ecc/bw6-756/shplonk/shplonk.go +++ b/ecc/bw6-756/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/ecc/bw6-761/shplonk/shplonk.go b/ecc/bw6-761/shplonk/shplonk.go index 96806b2e8..0880e5be4 100644 --- a/ecc/bw6-761/shplonk/shplonk.go +++ b/ecc/bw6-761/shplonk/shplonk.go @@ -146,8 +146,8 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) - bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) } diff --git a/internal/generator/shplonk/template/shplonk.go.tmpl b/internal/generator/shplonk/template/shplonk.go.tmpl index 0f510b4f4..253ed25bb 100644 --- a/internal/generator/shplonk/template/shplonk.go.tmpl +++ b/internal/generator/shplonk/template/shplonk.go.tmpl @@ -129,7 +129,7 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E copy(bufMaxSizePolynomials, polynomials[i]) riz := eval(ri[i], z) bufMaxSizePolynomials[0].Sub(&bufMaxSizePolynomials[0], &riz) // (fᵢ-rᵢ(z)) - mulByConstant(bufMaxSizePolynomials, gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) + mulByConstant(bufMaxSizePolynomials[:len(polynomials[i])], gammaiZtMinusSiZ) // γⁱZ_{T\Sᵢ}(z)(fᵢ-rᵢ(z)) for j := 0; j < len(bufMaxSizePolynomials); j++ { l[j].Add(&l[j], &bufMaxSizePolynomials[j]) }