1679 blockhash update #1681
Open
1679 blockhash update #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…acer into 1679-blockhash-update
OlivierBBB
approved these changes
Jan 11, 2025
we were previously extracting coinbaseWarmthAtTransactionEnd only in case of a rollback (exceptionalHalt or REVERT.) We now always extract it when the root context exits.
This prevents issues with multi block tests with different coinbases. This wasn't a surprise, rather a known issue that wasn't addressed until debugging BlockchainReferenceTest_601/SuicidesMixingCoinbase Which ought to be the final failing reference test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.