You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The OOGX tests are missing stuff. It's the same type of issue we already had with PUSH's but for SLOAD (and potentially for SSTORE). The issue is that in the tests storage is empty when tested. So SLOAD (which triggers OOGX) dredges up 0, which is indistinguishable from not writing anything. But when storage is nonempty the associated constraint storage-instruction---setting-storage-slot-values---doing-for-SLOAD blows up in case of an OOGX.
We may also have the same issue with MLOAD / MSTORE / MSTORE8 / CALLDATALOAD if the OOGX tests have, respectively:
empty memory
empty call data
We need ensure nontrivial results for the following opcodes:
// special crafted valuesSIGNEXTENDBYTESHRSAR// 0ISZERO// 1 and 1ANDEQ// some address in the state with nontrivial balance and codeBALANCEEXTCODEHASH// a value that is close to NUMBERBLOCKHASH// have nonempty RAM or nonempty CALLDATAMLOADCALLDATALOAD// should be called after having expanded memory onceMSIZE// generic 7 * i + 5 will do:ADDMULSUBDIVSDIVMODSMODADDMODMULMODEXPGTSGTEQSHLPUSHXSWAPXDUPX// generic 128 - 3 * i or soLTSLT
The text was updated successfully, but these errors were encountered:
The
OOGX
tests are missing stuff. It's the same type of issue we already had withPUSH
's but forSLOAD
(and potentially forSSTORE
). The issue is that in the tests storage is empty when tested. SoSLOAD
(which triggersOOGX
) dredges up 0, which is indistinguishable from not writing anything. But when storage is nonempty the associated constraintstorage-instruction---setting-storage-slot-values---doing-for-SLOAD
blows up in case of anOOGX
.We may also have the same issue with
MLOAD / MSTORE / MSTORE8 / CALLDATALOAD
if theOOGX
tests have, respectively:We need ensure nontrivial results for the following opcodes:
The text was updated successfully, but these errors were encountered: