fix xpath selector namespace handling for HTML DOMs #17
Labels
Comments
blahah
added a commit
that referenced
this issue
Apr 10, 2015
The npm xpath package has been updated to more closely match the xpath spec. However, this leads to problems using generic xpath selectors to select into a DOM rendered from normal HTML. Selectors that don't have a namespace fail to select anything. This behaviour makes scraping of the kind enabled by thresher impossible, but the previous version of the xpath lib was still the best working implementation we found in npm during testing. The fix is to bring the last working version of the xpath lib into this repo (it's only a single file). At a later stage, we can take later versions of the xpath lib that might have other improvements, but restore the historical handling of namespaces. This is tracked in issue #17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest versions of the xpath library break namespace-free selectors for normal HTML documents (goto100/xpath#27), so we're stuck using v0.0.6. For now this is fine, but eventually we should seek a resolution, either with a fork of the main xpath lib, or by just maintaining it inside this project.
The text was updated successfully, but these errors were encountered: