Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max-width for page? #45

Open
rgilman opened this issue Oct 1, 2018 · 4 comments
Open

Max-width for page? #45

rgilman opened this issue Oct 1, 2018 · 4 comments

Comments

@rgilman
Copy link
Member

rgilman commented Oct 1, 2018

I feel we should add an overall max-width (1200px?) for the page. Thoughts?

@rgilman
Copy link
Member Author

rgilman commented Oct 1, 2018

I should add what I see as some factors that enter into the question of max-width.

  1. The design does not include any full width banner images or anything else that requires full width.
  2. Text (as in forum posts) is more readable when it has width constraints.
  3. I'm expecting we will have dashboard pages (for each person and likely for each group) with activity streams (for messages, posts, blog posts, etc.) displayed in summary form. I'm envisioning these being in three columns in the wide display, accordion on mobile. Relative to max-width, the point is that there will be some pages where we want some width although 1200px should be ample.

@iangilman
Copy link
Member

Yes, we definitely want a max with for the text. It's possible we don't want it for the entire page, though. For instance, here in GitHub, the page header goes the entire width of the window, but the content has a max width. That seems like a reasonable model to follow.

@rgilman
Copy link
Member Author

rgilman commented Oct 1, 2018

Then let's start with a max-width below the header. Looks like it could be attached to <div class="content">.

It looks like GitHub uses 980px for their container width. I'm fine with anything in that range as a start – then we can play with it on various pages and look for the sweet spot.

We can leave until later the design question of whether the header should be full width or not.

@iangilman
Copy link
Member

Sounds good :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants