Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests [TODO] #9

Open
1 task
jeremymanning opened this issue Apr 27, 2023 · 12 comments
Open
1 task

Tests [TODO] #9

jeremymanning opened this issue Apr 27, 2023 · 12 comments
Labels
coding required Is coding required for this task? non-coding Task that doesn't require writing code
Milestone

Comments

@jeremymanning
Copy link
Member

Overview

Write unit tests for each function

Completion criteria

  • For each function, add a "todo" issue to create a test for the function, describing (a) what the function is supposed to do and (b) how it should be tested. If there are any edge cases or tricky scenarios to watch out for, those should be noted too

Resources (optional)

  • pytest: framework for writing and running tests
  • GitHub actions: can be used to automate tests when pull requests are merged
  • davos: archive contains useful code for running tests that involve notebooks

Discussion points

Adding issues doesn't require coding, but it'd be good to have at least one "coding" person work on this task to help define useful tests.

@jeremymanning jeremymanning added coding required Is coding required for this task? non-coding Task that doesn't require writing code labels Apr 27, 2023
@jeremymanning jeremymanning added this to the MVP milestone Apr 27, 2023
@xuyi0619 xuyi0619 self-assigned this Apr 27, 2023
@HemuManju
Copy link
Collaborator

@xuyi0619
Copy link
Collaborator

xuyi0619 commented May 4, 2023

Thank you so much !

@xuyi0619 xuyi0619 removed their assignment May 10, 2023
@HemuManju
Copy link
Collaborator

HemuManju commented May 18, 2023

@xuyi0619, hope you are doing well! I think the project is reaching a critical mass where we need extensive testing of the modules. Can we collaborate on this and write test cases?

@xuyi0619
Copy link
Collaborator

xuyi0619 commented May 18, 2023

Hi @HemuManju , of course!Let’s meet on zoom. I have time tomorrow, and next Tuesday and Thursday. Let me know which date and time works for you.

@HemuManju
Copy link
Collaborator

I am available on Tuesday.

@xuyi0619
Copy link
Collaborator

Ok, I will send you the zoom link when I get back.

@xuyi0619
Copy link
Collaborator

Grace Xu is inviting you to a scheduled Zoom meeting.

Topic: Grace Xu's Personal Meeting Room

Join Zoom Meeting
https://us04web.zoom.us/j/3252265589?pwd=eG1DVjRHSWtFQXFnOE5hK2NqRlgrZz09

Meeting ID: 325 226 5589
Passcode: TuXSp9

I am available on Tuesday.

@HemuManju
Copy link
Collaborator

Thanks @xuyi0619, at time are we meeting? I am on west coast.

@xuyi0619
Copy link
Collaborator

xuyi0619 commented May 22, 2023 via email

@HemuManju
Copy link
Collaborator

Works for me! Looking forward for the meeting.

@xuyi0619
Copy link
Collaborator

@HemuManju I am on zoom.

@jeremymanning
Copy link
Member Author

Some tests are hard to write, and others seem easier.

Hard tests

  • Making sure the interface renders correctly
  • Making sure the prompts are being sent to the LLM correctly
  • Testing the efficacy of the prompts
  • Checking formatting stuff (e.g., syntax highlighting, markdown rendering)

Easier tests

  • Verify that each type of LLM can be created without crashing, and can produce string outputs when called
  • Verify that a Chatify object can be created without crashing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding required Is coding required for this task? non-coding Task that doesn't require writing code
Projects
No open projects
Development

No branches or pull requests

3 participants