Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse #[sv::msg(reply=alias1|alias2, reply_on=...)] #426

Closed
Tracked by #418
jawoznia opened this issue Aug 30, 2024 · 0 comments · Fixed by #433
Closed
Tracked by #418

Parse #[sv::msg(reply=alias1|alias2, reply_on=...)] #426

jawoznia opened this issue Aug 30, 2024 · 0 comments · Fixed by #433
Assignees
Labels
part Part of a bigger issue

Comments

@jawoznia
Copy link
Collaborator

jawoznia commented Aug 30, 2024

Both aliases and reply_on are optional.

Aliases should be parsed as Idents.
Supported values for reply_on are:

  • Success
  • Failure
  • Always

If alias is not provided the Ident defaults to the marked method name.
If reply_on is not provided it defaults to Always.

@jawoznia jawoznia mentioned this issue Aug 30, 2024
12 tasks
@jawoznia jawoznia self-assigned this Aug 30, 2024
@jawoznia jawoznia added the part Part of a bigger issue label Aug 30, 2024
jawoznia added a commit that referenced this issue Aug 30, 2024
New optional parameters:
    - handlers - (handler1, handler2, ..)
    - reply_on - success|failure|always
jawoznia added a commit that referenced this issue Aug 30, 2024
New optional parameters:
    - handlers - (handler1, handler2, ..)
    - reply_on - success|failure|always
@jawoznia jawoznia linked a pull request Sep 3, 2024 that will close this issue
jawoznia added a commit that referenced this issue Sep 17, 2024
New optional parameters:
    - handlers - (handler1, handler2, ..)
    - reply_on - success|failure|always
@jawoznia jawoznia closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part Part of a bigger issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant