Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMTRIAGE-5616: Update Goss iPXE test to look for the x86-64 iPXE pod #2483

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

mharding-hpe
Copy link
Contributor

@mharding-hpe mharding-hpe commented Jun 28, 2023

Summary and Scope

In CSM 1.5, cray-ipxe now has two pods -- one which builds x86-64 binaries, and one which builds aarch64. The labels of these pods are both different from the previous iPXE pod label, which is causing a Goss test to fail. This test is run to ensure that NCN boots will work, so in that context we are only concerned with the x86-64 iPXE pod. The cmsdev test tool already includes more complete test coverage of iPXE, including the new aarch64 binaries, so it doesn't make sense to duplicate that here.

This modifies the test to use the correct label for the x86-64 pod.

Issues and Related PRs

Testing

I tested the updated kubectl command on ashton (installed with csm-1.5.0-alpha.66) and verified that it works.

Risks and Mitigations

Without this change, this test will always fail.

Pull Request Checklist

  • Copyrights updated
  • License file intact
  • Target branch correct
  • Testing is appropriate and complete, if applicable

@mharding-hpe mharding-hpe requested a review from a team as a code owner June 28, 2023 20:07
@mharding-hpe
Copy link
Contributor Author

/backport stable/1.5

@github-actions
Copy link

Backporting into branch stable/1.5 was successful. New PR: #2484

@mtupitsyn mtupitsyn merged commit 34b6718 into main Jun 28, 2023
1 check passed
@mtupitsyn mtupitsyn deleted the CASMTRIAGE-5616-main branch June 28, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants