Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMPET-6696: Update cert-manager api to /v1/ usage #2598

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

mitchty
Copy link
Contributor

@mitchty mitchty commented Jul 24, 2023

Summary and Scope

Since we have a /v1/ compliant cert-manager now, update usage of the certmanager api to /v1/ to be proactive about future updates which will remove all pre /v1/ api's entirely.

Issues and Related PRs

CASMPET-6696

  • Resolves [issue id](issue link)
  • Change will also be needed in <insert branch name here>
  • Future work required by [issue id](issue link)
  • Documentation changes required in [issue id](issue link)
  • Merge with/before/after <insert PR URL here>

Testing

dorian

Tested on:

  • <development system>
  • Local development environment
  • Virtual Shasta dorian

Test description:

Installed on dorian and let the issuers refresh after a day or two and validated we no longer have any old api usage for this chart.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
  • Were continuous integration tests run? If not, why?
  • Was upgrade tested? If not, why?
  • Was downgrade tested? If not, why?
  • Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

n/a not backwards compatible with pre 1.5 as that cert-manager only has alpha apis.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@mitchty mitchty requested a review from a team as a code owner July 24, 2023 16:42
@gbaker-hpe gbaker-hpe merged commit 1a0c1e5 into release/1.6 Jul 24, 2023
1 check passed
@gbaker-hpe gbaker-hpe deleted the CASMPET-6696-16 branch July 24, 2023 19:38
@gbaker-hpe
Copy link
Contributor

/backport

@github-actions
Copy link

Usage: /backport [--dry-run] <branch1> [<branch2> ...]

@gbaker-hpe
Copy link
Contributor

/backport release/1.5

@github-actions
Copy link

Backporting into branch release/1.5 was successful. New PR: #2599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants