CASMINST-6406 #2695
Merged
CASMINST-6406 #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustydb
commented
Aug 11, 2023
rustydb
commented
Aug 11, 2023
|
I'll make a backport to 1.6 once reviews settle. |
mtupitsyn
approved these changes
Aug 17, 2023
mtupitsyn
requested changes
Aug 17, 2023
There was a problem hiding this comment.
It looks like make -C images is not happy about having tds-cpu-requests.yaml under manifests/:
[2023-08-11T15:45:12.634Z] jq: error (at <stdin>:1): Cannot iterate over null (null)
[2023-08-11T15:45:12.891Z] ...Successfully got an update from the "csm-algol60" chart repository
[2023-08-11T15:45:12.891Z] bash: line 1: kill: (-2637) - No such process
[2023-08-11T15:45:12.891Z] make[1]: *** [Makefile:26: manifests/tds-cpu-requests.txt] Error 1
https://jenkins.algol60.net/job/Cray-HPE/job/csm/job/CASMINST-6406/1/display/redirect
This cleans up the root of the tarball, moving loose files into suitable directories. - `/install.deps-*.packages*` is removed - `/tds_cpu_requests.yaml` is renamed and moved into `/lib/` - `/pre-install-toolkit*.iso*` moved into `/images/pre-install-toolkit` - `/hpe-signing-key.asc` moved into `/security/`
mtupitsyn
approved these changes
Aug 18, 2023
mtupitsyn
approved these changes
Aug 18, 2023
|
/backport release/1.6 |
Merged
|
Backporting into branch release/1.6 was successful. New PR: #2727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the root of the tarball, moving loose files into suitable directories.
/install.deps-*.packages*is removed/tds_cpu_requests.yamlis renamed and moved into/lib//pre-install-toolkit*.iso*moved into/images/pre-install-toolkit/hpe-signing-key.ascmoved into/security/Before and after, using the csm-1.5.0-beta.34 tarball as an example.