Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMINST-6604 All images should come from csm-stable/sat-stable #2701

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

mtupitsyn
Copy link
Contributor

Summary and Scope

With csm build listing images coming from sources other then artifactory.algol60.net/csm-stable, we can't guarantee the image will be available next time when we want to re-use set of images. As of 1.5.0-rc.1, we have 3 images of this type:

docker.io/library/alpine:3.16    artifactory.algol60.net/docker.io/library/alpine@sha256:cbe5d5973103a2d03408d1689a6efde4ea4920bde9f4b51fe7872e60ce2d8e56
docker.io/library/alpine:latest    artifactory.algol60.net/docker.io/library/alpine@sha256:82d1e9d7ed48a7523bdebc18cf6290bdb97b82302a8a9c27d4fe885949ea94d1
quay.io/skopeo/stable:v1.4.1    artifactory.algol60.net/quay.io/skopeo/stable@sha256:0d95e6bce7365c5e8a9de347c2bacd6316d9a2593efd9f8d696545e67f32dcfa 

We need to change physical references to point to csm-stable, where we rebuild images at daily basis and retain digests if they are referenced by potential release bases. I.e. for

docker.io/library/alpine:3.16 

physical reference has to be

artifactory.algol60.net/csm-stable/docker.io/library/alpine@sha256:...

Until this is implemented, builds having CSM_BASE_VERSION will also have to have FAIL_ON_MISSED_IMAGE_DIGEST set to "true". Otherwise, build will fail on alpine:3.16 image digest, which is long gone, because that image was rebuilt externally and digest is not preserved in our cache. In other words, a build generated this way, is not the same as it's base - it has newer "alpine:3.16" image.

Issues and Related PRs

Testing

Tested on:

  • Local development environment
  • Jenkins

Test description:

Tested in different combinations of CSM_BASE_VERSION and FAIL_ON_MISSED_IMAGE_DIGEST inputs.

Risks and Mitigations

Not known atm.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@mtupitsyn mtupitsyn requested a review from a team as a code owner August 14, 2023 19:54
@mtupitsyn
Copy link
Contributor Author

/backport release/1.6

@github-actions
Copy link

Backporting into branch release/1.6 was successful. New PR: #2702

@denniswalker denniswalker merged commit 8988458 into release/1.5 Aug 15, 2023
1 check passed
@denniswalker denniswalker deleted the feature/reuse-images-1.5 branch August 15, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants