CRAYSAT-1917: Add unit tests for jinja_rendered decorator
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for usage of the `jinja_rendered` decorator on properties of the `BaseInputItem`. Modify these unit tests to simplify them slightly and to ensure that the `SomeTestItem` class calls the `BaseInputItem` constructor, so that it sets the `jinja_env` instance attribute, which is used by the `jinja_rendered` decorator. Test Description: Unit tests pass.
7 tasks
|
I'm not sure what the failing unit test is on the Jenkins build. Can you please take a look at that for me, @annapoorna-s-alt? |
annapoorna-s-alt
force-pushed
the
CRAYSAT-1917-add-jinja-rendered-unit-tests
branch
2 times, most recently
from
db2cede
to
6e42a20
Compare
annapoorna-s-alt
approved these changes
Nov 6, 2024
Update the unit tests of the InputSessionTemplate class to include tests that check for proper Jinja2 template rendering of the boot_sets field.
haasken-hpe
merged commit 2fa4583
into
CRAYSAT-1917-fix-jinja2-rendering
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Add unit tests for usage of the
jinja_rendereddecorator on properties of theBaseInputItem.Modify these unit tests to simplify them slightly and to ensure that the
SomeTestItemclass calls theBaseInputItemconstructor, so that it sets thejinja_envinstance attribute, which is used by thejinja_rendereddecorator.Issues and Related PRs
Testing
Tested on:
Test description:
Unit tests pass.
Risks and Mitigations
Low risk unit test improvements.