Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] maxSize must be set in bytes #27

Closed
lenamtl opened this issue Jun 1, 2022 · 0 comments
Closed

[bug] maxSize must be set in bytes #27

lenamtl opened this issue Jun 1, 2022 · 0 comments

Comments

@lenamtl
Copy link

lenamtl commented Jun 1, 2022

I found a validation error when trying to fix the PHP8 warning issue see #26

When I compare the $options['maxSize'] VS $file['size'] they use different size format so they cannot be compared correctly.

So maxSize must be set in bytes not megabytes (because the code does not have any conversion).
The value need to be changed in Javascript and in PHP.

@lenamtl lenamtl closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant