Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items in Placards loose custom names when disassembling contraptions #4997

Closed
Wuerfel21 opened this issue Jun 21, 2023 · 2 comments
Closed
Labels
type: bug Issue where something isn't working

Comments

@Wuerfel21
Copy link

Wuerfel21 commented Jun 21, 2023

Describe the Bug

When disassembling a contraption, all items contained in placards loose their custom names. (That it happens when disassembling is observed by using an item with name dependent Optifine CITs loaded. BTW, I have tested and the bug manifests with nothing but Create installed)

Reproduction Steps

  1. Build any contraption (I tested trains and elevators)
  2. Rename an item on an anvil and place it on a placard inside the contraption
  3. Assemble the contraption
  4. Disassemble the contraption
  5. Break the placard
  6. Custom item name is gone
    ...

Expected Result

Item name is retained

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Kubuntu 23.04

Mod Version

0.5.1b

Minecraft Version

1.19.2

Forge Version

43.2.14

Other Mods

No response

Additional Context

No response

@Wuerfel21 Wuerfel21 added the type: bug Issue where something isn't working label Jun 21, 2023
@Wuerfel21
Copy link
Author

Issue may be down in here: https://github.com/Creators-of-Create/Create/blob/mc1.18/dev/src/main/java/com/simibubi/create/foundation/utility/NBTProcessors.java#LL100C57-L100C57

@Wuerfel21
Copy link
Author

Fixed at 66797f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant