Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackPlacementOverlay throws errors and fails to render in production #5000

Closed
TropheusJ opened this issue Jun 22, 2023 · 0 comments
Closed
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working

Comments

@TropheusJ
Copy link
Collaborator

Describe the Bug

TrackPlacementOverlay will throw a million errors if it renders in production. In most cases it does not render, and when it does, it fails silently.
Here ObfuscationReflectionHelper is used to get a private value. It seems the srg name is supposed to be specified, not the mojmap name.
Only 1.19 was tested but it looks like this affects 1.18 too.

Reproduction Steps

Mess with tracks until the overlay renders

Expected Result

not causing errors

Screenshots and Videos

No response

Crash Report or Log

https://gist.github.com/TropheusJ/d515890844c84b876ab5f539bcf9787a

Operating System

Windows 10

Mod Version

0.5.1b

Minecraft Version

1.19.2

Forge Version

43.2.4

Other Mods

Architectury, Twilight Forest, Stonecutter Recipe Tags, Consistency+

Additional Context

Accessors are both more performant than reflection and more resistant to remapping issues

@TropheusJ TropheusJ added the type: bug Issue where something isn't working label Jun 22, 2023
@simibubi simibubi added the status: fixed in next release Issue will be fixed in the next release label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants