TrackPlacementOverlay throws errors and fails to render in production #5000
Labels
status: fixed in next release
Issue will be fixed in the next release
type: bug
Issue where something isn't working
Describe the Bug
TrackPlacementOverlay will throw a million errors if it renders in production. In most cases it does not render, and when it does, it fails silently.
Here ObfuscationReflectionHelper is used to get a private value. It seems the srg name is supposed to be specified, not the mojmap name.
Only 1.19 was tested but it looks like this affects 1.18 too.
Reproduction Steps
Mess with tracks until the overlay renders
Expected Result
not causing errors
Screenshots and Videos
No response
Crash Report or Log
https://gist.github.com/TropheusJ/d515890844c84b876ab5f539bcf9787a
Operating System
Windows 10
Mod Version
0.5.1b
Minecraft Version
1.19.2
Forge Version
43.2.4
Other Mods
Architectury, Twilight Forest, Stonecutter Recipe Tags, Consistency+
Additional Context
Accessors are both more performant than reflection and more resistant to remapping issues
The text was updated successfully, but these errors were encountered: