Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequenced Assembly recipes with same input item & filling as the first step not possible #5053

Closed
PssbleTrngle opened this issue Jul 2, 2023 · 1 comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working

Comments

@PssbleTrngle
Copy link
Contributor

Describe the Bug

Creating multiple assembly recipes using the same initial input is possible, if the first step is different in each recipe.
For example two recipes both using an iron plate as an input, but the first deploys an apple onto that, while the second deploys a gold ingot.
This however does not work, if the first step of the assembly recipe is a filling recipe, because the assembly step logic does only compare the items of the recipe container see here.

That means, if two assembly recipes both start with for example a glass bottle, but continue with a first step of filling different fluids into it, this method will always return the first of the two filling recipes, even if it does not actually match the fluid in the spout, because only the item (glass bottle) is checked

Reproduction Steps

  1. Create two assembly recipes both taking the same input
  2. Define a filling recipe with different fluid as the first step for both of them
  3. Define an arbitrary second step

Expected Result

Both recipes should work, since the first step is distinct (different fluids)

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.1b

Minecraft Version

1.19.2

Forge Version

43.2.4

Other Mods

No response

Additional Context

No response

@PssbleTrngle PssbleTrngle added the type: bug Issue where something isn't working label Jul 2, 2023
@PssbleTrngle
Copy link
Contributor Author

Looking a bit into the code, it looks like the RecipeWrapper would need a way to represent the fluid a spout is holding, in addition to the item inventory, which could be a big change

@simibubi simibubi added the status: fixed in next release Issue will be fixed in the next release label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: fixed in next release Issue will be fixed in the next release type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants