Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYVAM0 - Milyen macska vagy? #43

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

hgergely03
Copy link

@hgergely03 hgergely03 commented Dec 7, 2024

Closes #20

@hgergely03 hgergely03 marked this pull request as ready for review December 7, 2024 10:35
Copy link
Contributor

@webmaster442 webmaster442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Szép munka

{
private static int NormalizeAnswer(int answer)
{
return answer switch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pattern matching 👍

}

private static string CreateHtmlMarkup(Result result)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" idézőjellel lehet több soros szöveget megadni

{
public interface IDisplay
{
void GreetUser();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interfész segregation 👍

public enum Cat
{
Tabby = 0b_000_000,
Void = 0b_000_010,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miért binárisan? decimális vagy hexa?

[Test]
public void Test1()
{
Assert.Pass();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Üres teszt?

[Test]
public void Test1()
{
Assert.Pass();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Üres teszt?

[Test]
public void GetCatFact()
{
FactService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ez konkrétan szerintem nem is fordul így.


namespace BYVAM0_tests.Mocks
{
public class MockDisplay : IDisplay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ez nem mock, ez egy Fake. Különbségek:
Fake - Csak helyettesítő implementáció, ami semmit se csinál
Stub - Helyettesítő részleges implementáció
Spy - Helyettesítő részleges vagy teljes implementáció, ami lehetőséget ad a megfigyelésre is. Pl egy számlálón keresztül, hogy mennyiszer lett egy adott metódus meghívva.
Mock - Dinamikusan generált. Konfigurációtól függően lehet Fake, Stub vagy Spy is akár.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BYVAM0 - Milyen macska vagy?
2 participants