BAA45H - Költségvezető #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| static void Main() | ||
| { | ||
| IExpenseRepository repository = new JsonExpenseRepository(); |
There was a problem hiding this comment.
Noice 👍 Specifikált implementáció
| IUserInterface ui = new ConsoleUserInterface(); | ||
|
|
||
| MainMenu(ui, expenseService, repository); | ||
| ui.DisplayMessage("További szép napot és minél későbbi viszont látást!"); |
| string dateInput = ui.GetUserInput("Dátum (éééé-hh-nn): "); | ||
| if (dateInput == "0") return; | ||
|
|
||
| if (DateTime.TryParseExact(dateInput, "yyyy-MM-dd", null, System.Globalization.DateTimeStyles.None, out date)) |
There was a problem hiding this comment.
Ezt az if-else ágat el lehetne hagyni egy invertált if feltétellel, nem? Akkor nem kellene az else ág.
|
|
||
| if (int.TryParse(categoryInput, out categoryIndex)) | ||
| { | ||
| if (categoryIndex == categories.Count + 1) |
There was a problem hiding this comment.
Ez az if mergelhető a felette lévővel, nem?
| if (amountInput == "0") return; | ||
|
|
||
| if (decimal.TryParse(amountInput, out amount) && amount > 0) | ||
| { |
There was a problem hiding this comment.
Szintén meg lehetne fordítani a feltételt
| { | ||
| if (!File.Exists(filePath)) return new List<ExpenseRecord>(); | ||
| var jsonData = File.ReadAllText(filePath); | ||
| return JsonSerializer.Deserialize<List<ExpenseRecord>>(jsonData) ?? new List<ExpenseRecord>(); |
There was a problem hiding this comment.
Ilyenkor van értelme üreset visszaadni? Nem célszerűbb szétszállni a fenébe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.