Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix: /fast-forward triggered by non-maintainers #54

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

Young-Lord
Copy link
Contributor

@Young-Lord Young-Lord commented Jan 1, 2024

@CuteDress
Copy link
Member

你觉得可以合了就 @ 我

@Young-Lord
Copy link
Contributor Author

@CuteDress 这个可以了

@CuteDress
Copy link
Member

那我是直接用 fast-forward 合?

@Young-Lord
Copy link
Contributor Author

Young-Lord commented Jan 1, 2024

都行吧
感觉 /fast-forward 平时主要是给某些 clone 到本地自己给 commit 进行了签名的人用的,像这种纯 GitHub.com 在线编辑的怎么搞都行

@CuteDress
Copy link
Member

CuteDress commented Jan 1, 2024

还是手动 rebase merge 吧

Copy link

github-actions bot commented Jan 1, 2024

Triggered from #54 (comment) by @​CuteDress.

Trying to fast forward master (ca9919a) to patch-4 (18cbf54).

Target branch (master):

commit ca9919a19b30f25e6bcf53f3574934eda62ff5a3 (HEAD -> master, origin/master, origin/HEAD)
Author: LY <[email protected]>
Date:   Mon Jan 1 14:34:00 2024 +0800

    chore: don't treat `*.sig` GPG signatures as `Standard ML`
    
    ref:
    <https://github.com/github-linguist/linguist/issues/1298>
    <https://github.com/biergaizi/raspberrypi-sources/pull/1>

Pull request (patch-4):

commit 18cbf54710c224cfc24b69fbd97f40a054db7cfe (pull_request/patch-4)
Author: LY <[email protected]>
Date:   Mon Jan 1 15:11:13 2024 +0800

    ci: fix: `/fast-forward` triggered by non-maintainers

Fast forwarding master (ca9919a) to patch-4 (18cbf54).

$ git push origin 18cbf54710c224cfc24b69fbd97f40a054db7cfe:master
To https://github.com/Cute-Dress/Dress.git
 ! [remote rejected] 18cbf54710c224cfc24b69fbd97f40a054db7cfe -> master (refusing to allow a GitHub App to create or update workflow `.github/workflows/fast-forward.yml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/Cute-Dress/Dress.git'

@Young-Lord
Copy link
Contributor Author

Young-Lord commented Jan 1, 2024

改了 ci,fast-forward 不了(
permissions 里加上 workflows: write 可以解决,但没必要吧

@CuteDress CuteDress merged commit 8b4a2dd into Cute-Dress:master Jan 1, 2024
1 check passed
@CuteDress
Copy link
Member

都行吧 感觉 fast-forward 平时主要是给某些 clone 到本地自己给 commit 进行了签名的人用的,像这种纯 GitHub.com 在线编辑的怎么搞都行

确实,现在仓库太大不方便 clone,我也是直接在网页上操作的

@Young-Lord
Copy link
Contributor Author

顺带一提,这个/fast-forward不一定要单独作为一条评论,只要评论里包含就行了

@CuteDress
Copy link
Member

顺带一提,这个/fast-forward不一定要单独作为一条评论,只要评论里包含就行了

似乎在 review 的 approve 中带有/fast-forward时不会触发,如PR#58

@1193725591
Copy link

1193725591 commented Feb 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants