Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf defnitions for *Request structs #124

Open
blaggacao opened this issue Nov 7, 2020 · 1 comment
Open

Protobuf defnitions for *Request structs #124

blaggacao opened this issue Nov 7, 2020 · 1 comment

Comments

@blaggacao
Copy link

I want to build the following protobuf:

syntax = "proto3";

package vicigo.dialer.commands;

option go_package = "commands";

import "google/protobuf/timestamp.proto";
import "github.com/CyCoreSystems/ari/ari.proto"; // here, I'd like to have all request structs available.

message Originate {
  asterisk.ari.OriginateRequest req = 1; // here is how I would like to use it.

  string agent_load_balance_strategy = 2;
  ...
}

Would that be possible / a PR accepted?

@blaggacao blaggacao changed the title Protobuf defnitinos for *Request structs Protobuf defnitions for *Request structs Nov 7, 2020
@Ulexus
Copy link
Member

Ulexus commented Jan 7, 2022

Makes sense. I've started several times converting all the basic structs to protobuf, but I never end up liking it. The code generator just needs to be extended to do this.

PRs welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants