New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless code #189

Open

hezanathos opened this issue Aug 10, 2020 · 0 comments

Assignees

Member

hezanathos commented Aug 10, 2020

https://github.com/fenrisl/cyberwatch_api_toolbox/blob/convert_json/cbw_api_toolbox/cbw_api.py#L221 is a good example.
We should let the user specify the full dictionary and post it without any treatment. This would allow api changes with no lib effect and decrease the risk of bugs in our code.

Check all post to see if they map the user input into a new dictionnary and change it

Change the api documentation examples accordingly ( for example 'auth_password' would no longer be accepted )

hezanathos assigned fenrisl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment