Skip to content
This repository has been archived by the owner on Jun 20, 2019. It is now read-only.

Fix unit tests for core.internal.convert and rt.util.typeinfo #768

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from

Conversation

jpf91
Copy link
Contributor

@jpf91 jpf91 commented Nov 18, 2018

https://bugzilla.gdcproject.org/show_bug.cgi?id=309

@ibuclaw Here for review an CI. Once you think this is ready, I'll post to gcc-patches.

@jpf91 jpf91 requested a review from ibuclaw November 18, 2018 10:45
@ibuclaw
Copy link
Member

ibuclaw commented Nov 18, 2018

What if e1 or e2 have a side effect? They should be a save_expr in that case.

@ibuclaw
Copy link
Member

ibuclaw commented Nov 18, 2018

Actually, to clarify, they should be saved before extracting the real and imag parts.

@jpf91
Copy link
Contributor Author

jpf91 commented Nov 18, 2018

So can I just move d_save_expr out of build_float_identity and apply it on the 'top-level' expressions?

@jpf91
Copy link
Contributor Author

jpf91 commented Nov 18, 2018

OK.

@ibuclaw
Copy link
Member

ibuclaw commented Nov 18, 2018

So can I just move d_save_expr out of build_float_identity and apply it on the 'top-level' expressions?

Right. You don't need to save anything for ordinary float comparison (I might be forgetting something though).

@jpf91
Copy link
Contributor Author

jpf91 commented Nov 18, 2018

You don't need to save anything for ordinary float comparison (I might be forgetting something though).

The original code did save float expressions though, so I've also kept that in the commit I just pushed.

@jpf91
Copy link
Contributor Author

jpf91 commented Nov 18, 2018

Is this ready for gcc-patches?

@ibuclaw
Copy link
Member

ibuclaw commented Nov 18, 2018

I don't see why not. You could always just post to gcc-patches anyway and discuss the patch and make changes there. ;-)

I am yet to get round to fixing up this repo to use as a mirror/ci.

@jpf91
Copy link
Contributor Author

jpf91 commented Nov 24, 2018

@ibuclaw

Note that the XGDC bugs in convert.d seem to be fixed as well, or at least I can't reproduce these on x86_64.

@jpf91 jpf91 changed the title Fix IdentityExp comparison for complex floats Fix unit tests for core.internal.convert and rt.util.typeinfo Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants