Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js bug: changes in patient dashboard getting eaten #3240

Open
colinxfleming opened this issue Jul 29, 2024 · 4 comments
Open

Js bug: changes in patient dashboard getting eaten #3240

colinxfleming opened this issue Jul 29, 2024 · 4 comments
Milestone

Comments

@colinxfleming
Copy link
Member

colinxfleming commented Jul 29, 2024

Thanks for creating an issue! Please fill out this form so we can be sure to have all the information we need, and to minimize back and forth.

  • What are we trying to do?

Modernize the Patient Dashboard and make sure we don't lose any data.

  • What feature or behavior is this required for?

  • How could we solve this issue? (Not knowing is okay!)

We need to investigate what change in the newer Reactified PatientDashboardForm wasnt saving data correctly, fix that bug, and reintroduce the reactified call we reverted in #3237!

  • Anything else?

Data-eating behavior can be observed on 03cf6ad

@lomky
Copy link
Member

lomky commented Jul 31, 2024

No longer true in production after #3237, but we should debug and rerelease!

@lomky lomky added this to the Hacknights! milestone Sep 11, 2024
@rkaufman13
Copy link
Contributor

Investigating this but don't let me having 'claimed' this stop anyone else from looking into it.

@rkaufman13
Copy link
Contributor

Couldn't replicate locally on the referenced commit. @lomky suggested spinning up a separate Heroku instance to try to debug in the wild.

@F00bis
Copy link

F00bis commented Sep 12, 2024

Suspect the issue has something with JS implicit semicolon insertion in the autosave function. We need to make a test branch that reverts #3237 and inserts semicolons to run on a live heroku instance to see if this hunch pays off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants