Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61: Create configuration validator #119

Merged
merged 9 commits into from
Sep 27, 2024

Conversation

maxime-bfsquall
Copy link
Contributor

Fixes #61

@ppebay ppebay self-requested a review September 19, 2024 11:32
bindings/python/tv.cc Outdated Show resolved Hide resolved
tests/test_bindings.py Outdated Show resolved Hide resolved
tests/test_bindings.py Outdated Show resolved Hide resolved
tests/test_bindings.py Outdated Show resolved Hide resolved
bindings/python/config_validator.h Outdated Show resolved Hide resolved
tests/test_bindings.py Outdated Show resolved Hide resolved
tests/test_bindings.py Outdated Show resolved Hide resolved
bindings/python/config_validator.h Outdated Show resolved Hide resolved
bindings/python/config_validator.h Outdated Show resolved Hide resolved
@tlamonthezie
Copy link
Contributor

@maxime-bfsquall Could you please check ci failures. There seems to be some python error.

@ppebay
Copy link
Contributor

ppebay commented Sep 27, 2024

@tlamonthezie I am fine with the current version of the PR; are you still seeing the CI failures you were describing previously
?

@maxime-bfsquall Could you please check ci failures. There seems to be some python error.

bindings/python/config_validator.cc Outdated Show resolved Hide resolved
bindings/python/config_validator.cc Outdated Show resolved Hide resolved
bindings/python/config_validator.h Outdated Show resolved Hide resolved
bindings/python/tv.cc Outdated Show resolved Hide resolved
tests/test_bindings.py Outdated Show resolved Hide resolved
tests/test_bindings.py Show resolved Hide resolved
bindings/python/tv.cc Show resolved Hide resolved
bindings/python/config_validator.cc Outdated Show resolved Hide resolved
bindings/python/config_validator.cc Outdated Show resolved Hide resolved
bindings/python/tv.cc Outdated Show resolved Hide resolved
@tlamonthezie
Copy link
Contributor

@tlamonthezie I am fine with the current version of the PR; are you still seeing the CI failures you were describing previously ?

@maxime-bfsquall Could you please check ci failures. There seems to be some python error.

@ppebay the CI is now ok. Previous failures have been resolved.

@maxime-bfsquall maxime-bfsquall merged commit 6617f3a into master Sep 27, 2024
12 checks passed
@maxime-bfsquall maxime-bfsquall deleted the 61-create-configuration-validator branch September 27, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create configuration validator
3 participants