Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8: Adapt input and output to use compressed JSON format #106

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cwschilly
Copy link
Contributor

@cwschilly cwschilly commented Aug 14, 2024

Fixes #8

This changes vttv so that we read in every file in the input data directory. This means that there can't be extra files in there (for example, both compressed and un-compressed versions of the input data).

Also reworks OpenMP preprocessing, since the changes to JSON reading affected the omp parallel for in parse_render.cc.

@cwschilly cwschilly linked an issue Aug 14, 2024 that may be closed by this pull request
@cwschilly cwschilly self-assigned this Aug 14, 2024
@cwschilly cwschilly force-pushed the 8-adapt-input-and-output-to-use-compressed-json-format branch from bf90fe6 to b651602 Compare August 26, 2024 16:11
@cwschilly
Copy link
Contributor Author

cwschilly commented Aug 27, 2024

I think the remaining test failure is due to object jitter in the png outputs--this should be resolved by PR #96

@cwschilly cwschilly force-pushed the 8-adapt-input-and-output-to-use-compressed-json-format branch from a187dc8 to 4bd910e Compare September 4, 2024 13:44
@tlamonthezie tlamonthezie force-pushed the 8-adapt-input-and-output-to-use-compressed-json-format branch from 6da8f58 to 0f6c187 Compare September 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt input and output to use compressed JSON format
2 participants