Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoI In Optimize to be in result dataset #5730

Open
Tom-Szendrey opened this issue Dec 3, 2024 · 2 comments
Open

QoI In Optimize to be in result dataset #5730

Tom-Szendrey opened this issue Dec 3, 2024 · 2 comments
Assignees

Comments

@Tom-Szendrey
Copy link
Contributor

Tom-Szendrey commented Dec 3, 2024

We will want to add the QoI to the resulting dataset saved in optimize run.
This will be a new column named: QoI_{Criteria_name} OR QoI_#.
Note that this name needs to be unique so having the criteria name is helpful for user readability but potentially bad for uniqueness.

This new column will be filled in with the value of the corresponding sample_id's qoi for each timepoint.
This will mean the QoI chart within the node should not be reactive (this is already probably a smart idea anyways)

@Tom-Szendrey Tom-Szendrey self-assigned this Dec 3, 2024
@Tom-Szendrey
Copy link
Contributor Author

There have been discussions to move our logic from #5731 to the ciemss team.
This may also be used for adding the QoI column to the sample output.

Ciemss PR to review before more discussions:
ciemss/pyciemss#635

@Tom-Szendrey
Copy link
Contributor Author

This is a ticket to add the quality of interest stats which are used to generate the chart in the screen capture below.
The benefit of adding this information to the simulation data produced by optimize is that the user can then later examine this information to better understand their results.
They can examine this by downloading the csv or by using our dataset-transformer

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant