Remove edit functions from API endpoints #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the class inheritance for the
ChantList,ChantDetail,FolioList,FolioDetail,ConcordanceList,ConcordanceDetail,ManuscriptListandManuscriptDetailviews.*Listviews used to inherit from Django Rest Framework'sListCreateAPIViewwhich allowed for both GET and POST requests.*Detailviews used to inherit from Django Rest Framework'sRetrieveUpdateDestroyAPIViewwhich allowed GET, PUT, PATCH, and DELETE requests. At this time, only GET requests are required on those endpoints, and other request types had been previously allowed without authentication or verification. The now inherit fromListAPIViewandRetrieveAPIViewwhich only provides GET requests.This PR closes #721, where a complete inventory of Cantus Ultimus's API endpoints was also undertaken to verify which views allowed these types of edit requests.