Stop chant audio when chant is changed #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmarchd01
approved these changes
Aug 24, 2023
|
I'm going to revise this PR after discussion with @annamorphism ... we want to stop the sound when you open a new chant or close the current chant, but because some chants continue across folios (note open issue #628), we want users to be able to scroll to a new folio but have the sound continue. |
Listens to a click on any chant accordion header to stop audio, but keeps audio playing even if user has scrolled to a new image.
|
@jacobdgm @lucasmarchd01 Just putting this on your radar ... Lucas approved this but then I made substantial changes based on feedback from Anna, so would love another look from either one of you. TY!! |
jacobdgm
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #767. Playing audio is stopped when the chant is changed by:
a. Closing the open chant accordion panel;
b. Opening a new chant accordion panel; or
c. Scrolling to a new image.