Redirect to ManuscriptListView when manuscript is not found #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not do both? Return a 404 (signalling to browsers, caches, search engines, etc. that it's no longer there) but with a custom 404 page pointing to the MSS list, and letting the users know that they should update their bookmarks. |
|
Ok, this makes sense! thank you |
|
jacobdgm
approved these changes
Nov 21, 2023
| to return a custom 404 page if the manuscript | ||
| is not found. Implemented to prevent generic | ||
| 404 errors from links to specific manuscripts | ||
| made before manuscript ids were stable. |
| <div class="row" style="padding-top:20vh;padding-bottom:20vh"> | ||
| <div class="col-lg-12"> | ||
| <p class="text-center">This manuscript has been moved.</p> | ||
| <p class="text-center">You can find it on <a href="{% url 'manuscript-list' %}">the Manuscripts page</a>.</p> |
There was a problem hiding this comment.
should the link be applied to "Manuscripts page", or even just "Manuscripts"? Including the article feels weird to me.
Both the title and the path of the page in question use just "manuscripts". Suggesting you move the "the" and the "page" out of the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides the default
retrievemethod of the ManuscriptDetailView class so that when a manuscript with the requested ID is not found, a custom404page is returned that directs users to the ManuscriptListView (see below).As mentioned in the function's comment, this is meant to mitigate cases where a link to a specific manuscript was published before manuscripts in Cantus Ultimus had stable ID's.
Closes #802
Custom 404 Page
https://user-images.githubusercontent.com/11023634/284639619-89ed0747-a41a-46ae-82f8-a69cdda4b741.png