Add IIIF attribution and licence information to "Manuscript Info" sidebar #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
requested review from
jacobdgm and
lucasmarchd01
and removed request for
jacobdgm and
lucasmarchd01
dchiller
force-pushed
the
i-786-IIIF-requiredStatement-and-provider
branch
from
de3d37b
to
70e657f
Compare
jacobdgm
requested changes
Jan 11, 2024
nginx/public/node/frontend/public/js/app/manuscript-detail/manuscript-info.template.html
Outdated
Show resolved
Hide resolved
nginx/public/node/frontend/public/js/app/manuscript-detail/manuscript-info.template.html
Outdated
Show resolved
Hide resolved
jacobdgm
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information about the source and licensing for images used on Cantus Ultimus to the "Manuscript Info" sidebar on the Manuscript Detail view.
IIIF manifests conforming to the Presentation API v 2 may have
attribution,license, andlogoattributes that contain an attribution statement, a link to image licensing information, and a link to a logo of the providing institution, respectively. The contents of theattributionattribute must be shown, while showing the other two are optional. This PR opts to show any of the three that are available.The associated issue #786 references a
requiredStatementfield. This was introduced with the IIIF Presentation API v 3. No manifests currently on Cantus Ultimus use v 3 of the API, and Diva does not currently support v 3, so I've opted not to supportrequiredStatementhere. In the even that support of v 3 of the Presentation API is necessary, then changes to how image attribution is shown will need to occur.Closes #786.
Screenshots showing how this looks on a few different manuscripts:
