Update deployment configurations and ports #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the DEVELOPMENT environment variable, rather than the PORT variable, to determine whether to run in development or deployment mode. Always listen on port 8000, since nginx does not need to serve over http or https (this is handled by edge routers).
jacobdgm
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR:
nginxcontainer now always listens on the server's port8000since it is only serving to the edge routerDEVELOPMENTenvironment variable rather than the much more opaquePORTvariablemakemigrationsandmigratecommands are no longer run automatically at server start-up, since migrations are now committed to version control (introduced in Remove concordance model and related code #809)Closes #818.
NOTE: This PR will require a PR to the operations repo to ensure that the edge routers route requests to port 8000.