Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minor build fixes #871

Merged
merged 7 commits into from
May 31, 2024
Merged

Conversation

dchiller
Copy link
Collaborator

@dchiller dchiller commented May 27, 2024

This PR introduces a number of relatively minor container building and configuration related fixes that I've been collecting while developing.

  • Rather than randomly creating a new django secret key every time the django container is built, we set the secret key using the .env file. This allows us to keep the same secret key across multiple container builds and also make use of django settings for linting and type checking in development.
  • There were two "versions" of the same version of solrpy running around. The one on pypi had a very annoying extra print statement that clogged up the logs, while the release on the solrpy repository did not have that print statement. This PR switches those out in the python dependencies.
  • This PR adds the psycopg binary version to our dependencies, since we don't need to use the pure python implementation.
  • In Update deployment configurations and ports #819, we switched from using the PORT environment variable to signal when we were running in development mode to using a more aptly named DEVELOPMENT variable, but we didn't modify the rest of the app container build process to properly make use of this new variable. We do that here.
  • The celery app was using some convoluted methods to get its settings. We simplify that in 9a21998

The version of solrpy shipped with an errant print statement,
so we use the release tag on GitHub instead.
Rather than choosing a new, random secret key every container build,
we pass the secret key in from environment variables.
Use .get in accessing RabbitMQ settings

Add `django_extension` in INSTALLED_APPS only at debug
@dchiller
Copy link
Collaborator Author

@lucasmarchd01 could you take a look?

@@ -18,6 +18,7 @@ jobs:
RABBIT_USER: admin
RABBIT_PASSWORD: supersecurepassword99
PORT: "8000"
DJANGO_SECRET_KEY: verygoodandsecurekey123456123465@@123456
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@dchiller dchiller merged commit 8a1d2f6 into DDMAL:main May 31, 2024
2 checks passed
@dchiller dchiller deleted the minor-build-fixes branch May 31, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants