Implement Interval search #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add extraction of melodic intervals in mei_parser and mei_tokenizer - modify mei_processing types to include melodic intervals in parsed MEI and ngrams - modify search_notation_view to include intervals search processing, with validation and query modification processes added to search_utils.py - minor lint fixes for index_manuscript_mei_command - add associated tests for above changes
- Adds interval search to the OMRSearchProvider - Creates front-end helpers for entering interval search
lucasmarchd01
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-implements interval search using OMR-ed data. It adds both back-end and front-end support for this type of search.
A part of the front-end, it adds a helper interface where users can use buttons to add intervals to the search string.
Included two peripheral changes in this PR:
schema.xmlwith no substantive changesdjlintdependency forhtmltemplate formatting to thedevgroupCloses #875.