Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++11 warnings result in build failure. #110

Open
edsu opened this issue Apr 23, 2019 · 1 comment
Open

C++11 warnings result in build failure. #110

edsu opened this issue Apr 23, 2019 · 1 comment

Comments

@edsu
Copy link

edsu commented Apr 23, 2019 •
edited
Loading

When building on Ubuntu I'm seeing warnings like this that ultimately result in a build failure:

In file included from /code/libmei-3.1.0/src/meiattribute.cpp:2:0:
/code/libmei-3.1.0/src/meielement.h:181:44: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
         void setDocument(MeiDocument *doc) throw (DocumentRootNotSetException);

Normally warnings are not considered errors, but the compiler is being asked to make them errorrs. When I remove those lines the build succeeds.
@mprevot
Copy link

mprevot commented Jul 16, 2019

For non developers, adding add_definitions( -w ) to silent warnings is also a good thing to do.

JRegimbal added a commit to JRegimbal/libmei that referenced this issue Jul 22, 2020
@JRegimbal
No errors on deprecated warnings
ec5d913 
Since some features are deprecated (and more possibly will be
eventually), keep errors on warnings (-Werror) but also add an exception
to just warn on deprecation (-Wno-error=deprecated) rather than fail.

This keeps deprecation warnings visible and also causes more serious
warnings (like uninitialized variables/pointers) to error.

This addresses issue DDMAL#110.
@JRegimbal JRegimbal mentioned this issue Jul 22, 2020
Open
JRegimbal added a commit to JRegimbal/libmei that referenced this issue Aug 7, 2020
@JRegimbal
No errors on deprecated warnings
0461bbf 
Since some features are deprecated (and more possibly will be
eventually), keep errors on warnings (-Werror) but also add an exception
to just warn on deprecation (-Wno-error=deprecated) rather than fail.

This keeps deprecation warnings visible and also causes more serious
warnings (like uninitialized variables/pointers) to error.

This addresses issue DDMAL#110.
rettinghaus pushed a commit to eNote-GmbH/libmei that referenced this issue Jul 1, 2022
@JRegimbal @rettinghaus
No errors on deprecated warnings
96a6e61 
Since some features are deprecated (and more possibly will be
eventually), keep errors on warnings (-Werror) but also add an exception
to just warn on deprecation (-Wno-error=deprecated) rather than fail.

This keeps deprecation warnings visible and also causes more serious
warnings (like uninitialized variables/pointers) to error.

This addresses issue DDMAL#110.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edsu @mprevot