From 6567aa872554a408baee19d0f610669d5bccf2c8 Mon Sep 17 00:00:00 2001 From: Tyler Mees Date: Thu, 18 Apr 2024 13:23:22 +0200 Subject: [PATCH 1/3] feat: log errors during faculty processing --- main/models.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/main/models.py b/main/models.py index bf94d82b0..da2c59759 100644 --- a/main/models.py +++ b/main/models.py @@ -1,8 +1,11 @@ +import logging + from django.contrib.auth import get_user_model from django.contrib.auth.models import User from django.db import models from django.utils.translation import ugettext_lazy as _ +logger = logging.getLogger("ethics.main") class YesNoDoubt(models.TextChoices): YES = "Y", _("ja") @@ -159,6 +162,6 @@ def process_faculties(self, faculties): continue faculty_obj.users.add(self) - except: - # Just ignore any errors... + except Exception as e: + logger.error(f"Error processing faculty for user: {e}", exc_info=True) continue From 5406414deba665d23e1b2d7c0b8334b357940b86 Mon Sep 17 00:00:00 2001 From: Tyler Mees Date: Thu, 18 Apr 2024 13:27:01 +0200 Subject: [PATCH 2/3] style: please Black --- main/models.py | 1 + 1 file changed, 1 insertion(+) diff --git a/main/models.py b/main/models.py index da2c59759..8bd785ecc 100644 --- a/main/models.py +++ b/main/models.py @@ -7,6 +7,7 @@ logger = logging.getLogger("ethics.main") + class YesNoDoubt(models.TextChoices): YES = "Y", _("ja") NO = "N", _("nee") From 4266b5dd40fc632d825754bdadaf1926e6c70553 Mon Sep 17 00:00:00 2001 From: Tyler Mees Date: Wed, 24 Apr 2024 14:41:57 +0200 Subject: [PATCH 3/3] refactor: remove string-formatting in logging --- main/models.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main/models.py b/main/models.py index 8bd785ecc..3663e4550 100644 --- a/main/models.py +++ b/main/models.py @@ -163,6 +163,6 @@ def process_faculties(self, faculties): continue faculty_obj.users.add(self) - except Exception as e: - logger.error(f"Error processing faculty for user: {e}", exc_info=True) + except: # noQA + logger.error(f"Error processing faculty for user", exc_info=True) continue