-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SendChunkedMessageTest | Failing since the messages are not matching any longer #197
Comments
saschadoemer
added a commit
that referenced
this issue
Dec 15, 2023
Disabled two tests in the 'SendChunkedMessageTest' and 'SendChunkedMessageForSingleChunkTest' classes needing further investigation and attributed them to issues #197 and #198 respectively. Created 'SendChunkedMessageForSingleChunkTest' file. Changed the error code assertion from string to integer in 'OnboardingWithErrorMessageTest'.
saschadoemer
added a commit
that referenced
this issue
Dec 15, 2023
* Refactor telemetry onboarding response's formatting Formatted the telemetry platform and platform-removed onboarding responses data. The response's payloads are now presented in a more structured, neatly indented JSON format for better readability and clarity. * Improve README documentation formatting Adjusted the formatting of the README documentation file to enhance readability and content clarity. The modifications include structuring sentences into separate lines, delivering concise and clear information more efficiently. * Improve file formatting and optimize SVGs The commit updates the formatting of several files for improved readability and also optimizes SVG graphics for faster load times. It primarily involves adding appropriate line breaks and spaces for clarity and enhancing readability in bug report template and the code of conduct. Optimization of SVGs results in more efficient loading and display of images. * Change error code type from String to Int Data types of 'code' fields in RevokingError and OnboardingError classes have been changed from strings to integers. This will streamline error handling and avoid potential type conversion errors. The default error code for unknown errors has also been updated from "UNKNOWN_ERROR" to -1. * Update test classes, disable tests needing investigation Disabled two tests in the 'SendChunkedMessageTest' and 'SendChunkedMessageForSingleChunkTest' classes needing further investigation and attributed them to issues #197 and #198 respectively. Created 'SendChunkedMessageForSingleChunkTest' file. Changed the error code assertion from string to integer in 'OnboardingWithErrorMessageTest'. * Remove redundant encoding in EncodeMessageServiceImpl Removed use of StandardCharsets.UTF_8 in EncodeMessageServiceImpl as the payloads were already in byte format. Eliminating this redundant encoding to UTF_8 from the payload improves efficiency and mitigates potential errors due to unnecessary conversion scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: