New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent setter #32

Open

lmis-rom opened this issue Feb 28, 2021 · 0 comments

Labels

nice2have

Collaborator

lmis-rom commented Feb 28, 2021 •

edited

Loading

Sometimes fluent setter, sometimes normal. fluent setter mostly not used:

example: src/Api/Builder/CapabilityBuilder.php:withTaskdata

$capability = new Capability();
$capability->setDirection($direction);
$capability->setTechnicalMessageType(CapabilityTypeDefinitions::ISO_11783_TASKDATA_ZIP);

could be for example:

$capability = (new Capability())
->setDirection($direction)
->setTechnicalMessageType(CapabilityTypeDefinitions::ISO_11783_TASKDATA_ZIP);

The text was updated successfully, but these errors were encountered:

lmis-rom added the nice2have label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment