Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid call to DateTime constructor #49

Open
oliverrahner opened this issue Mar 8, 2024 · 1 comment · May be fixed by #51
Open

Invalid call to DateTime constructor #49

oliverrahner opened this issue Mar 8, 2024 · 1 comment · May be fixed by #51
Assignees
@saschadoemer

Comments

@oliverrahner
Copy link
Member

DateTime constructor must not be called with null for the $datetime parameter: https://www.php.net/manual/en/datetime.construct.php

agrirouter-sdk-php/src/Service/Common/UtcDataService.php

Line 25 in 44daf1b

$d = new DateTime(null, new DateTimeZone('UTC'));

Replacing null with "now" should do the trick.
@oliverrahner oliverrahner linked a pull request Mar 8, 2024 that will close this issue
Open
@oliverrahner
Copy link
Member Author

The test case currently fails for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saschadoemer saschadoemer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed DateTime constructor call DKE-Data/agrirouter-sdk-php
2 participants
@saschadoemer @oliverrahner