Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThermofluidStream.Examples.SimpleAirCycle #217

Open
RaphaelGebhart opened this issue Oct 18, 2024 · 5 comments
Open

ThermofluidStream.Examples.SimpleAirCycle #217

RaphaelGebhart opened this issue Oct 18, 2024 · 5 comments

Comments

@RaphaelGebhart
Copy link
Contributor

RaphaelGebhart commented Oct 18, 2024

Isses about ThermofluidStream.Examples.SimpleAirCycle;

  1. I first thought the two sides of the model represent left and right pack of an aircraft. It took a while, until i understood, that this is not intended by the model and that the sides are actually two seperate models, that would never be combined into one aircraft. Therefor i suggest to highlight it by using seperate inlets and outlets for simple cycle and three wheel bootstrap cycle.

  2. It would be beneficial to explain the ram air boundary conditions, i.e. p_in = 0.3 bar is the total pressure, T_in = -30 °C is the total temperature and p_out = 0.22 bar is the static pressure. Those values correspond to a static temperature T = -50.6 °C and velocity v = -203.5 m/s = 730 km/h. The static pressure and static temperature approximately correspond to an altitude h = 11.1km and a temperature difference of dT = 5.9 K to ISA0 (Actually h = 11.1km is slightly above the limit of troposphere h = 11km and i did not check the exponent in the tropopause but the 100m dont matter a lot i guess). That means: the boundary conditions are meaningful, but one needs some knowledge to check where they come from.

  3. The fan has a pressure ratio pr = 0.53/0.3 = 1.76, the compressor has a pressure ratio pr = 3.0/2.5 = 1.2 which does not seem realistic to me. In my opinion the main reason is the rather bad implementation of ThermofluidStream.Processes.Internal.TurboComponent.dp_tau_const_isentrop. The example prooves that even for an official example we can not manage to design turbocomponents using the function. I made another issue for this implementation.

  4. The simple cycle yields outlet temperature T_out = -2.37°C and a mass flow rate m_flow = 0.514 kg/s, the three wheel bootstrap cycle yields outlet temperature T_out = -1.57°C and a mass flow rate m_flow = 0.507 kg/s, i.e. from this example one would conclude that a simple cycle yields better performance (lower outlet temperature and higher mass flow rate) at lower complexity/weight/higher safety than a three wheel bootstrap cycle. I think we should reconsider that.

  5. It might be beneficial to use displayInstanceNames, displayParameters, rename components and order them correctly to simplify the use of the example.

  6. For a better overview sensors/displays might be beneficial too.

@IngelaLind
Copy link
Contributor

IngelaLind commented Oct 18, 2024 via email

@RaphaelGebhart
Copy link
Contributor Author

RaphaelGebhart commented Oct 18, 2024

Yes we might consider if some one wanna write a thesis and implement a nice compressor/fan/turbine component, im not sure if i have enough time...

@IngelaLind
Copy link
Contributor

IngelaLind commented Oct 18, 2024 via email

@RaphaelGebhart
Copy link
Contributor Author

Yes sorry, first I got it wrong :)

@tobolar
Copy link
Contributor

tobolar commented Oct 21, 2024

@RaphaelGebhart Your comments are all fine. Additionally, this shall be documentad accordingly in the model. (I suppose you are not the only person who misunderstand the example.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants