Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish Validator now flags link to Assembly #599

Open
baemyung opened this issue Aug 1, 2024 · 4 comments
Open

Redfish Validator now flags link to Assembly #599

baemyung opened this issue Aug 1, 2024 · 4 comments

Comments

@baemyung
Copy link

baemyung commented Aug 1, 2024

The latest Redfish Service Validator change ab8e447 verifies the links.

We have the following link in Cables:

"DownstreamResources": [
            {
                "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/17"
            }
        ],

Which throws the error:

Links.DownstreamResources[0]	Link: /redfish/v1/Chassis/chassis/Assembly#/Assemblies/24	link: Resource	Yes	FAIL

ERROR - DownstreamResources: Linked resource is not the correct type; found Assembly.v1_3_0.AssemblyData, expected Resource.Resource

We have a bunch of Simple Inventory (Field Replaceable Units (FRUs)) that we model as Assemblies... They have properties like an Identify LED, Part Number, but not much else. In this case, the Downstream Resource is a DASD (direct access storage device) Backplane.

Can Cable DownstreamResouces allow for Assembly.AssemblyData ?

@mraineri
Copy link
Contributor

mraineri commented Aug 2, 2024

"DownstreamResources" is defined as "Resource.Resource" to point to any resource in the model. However, "AssemblyData" in Assembly is NOT a resource; it's a "referenceable member" object. So, no, DownstreamResources cannot be used to point to an individual AssemblyData like that.

@mraineri
Copy link
Contributor

mraineri commented Aug 2, 2024

Now, maybe there's a broader modeling question we need to ask the Redfish Forum; should we change the DownstreamResources link to allow for referenceable member objects?

@baemyung
Copy link
Author

baemyung commented Aug 5, 2024

@mraineri
Thanks for explaining the cause.
What should I do to go forward asking the modeling question?

@mraineri
Copy link
Contributor

mraineri commented Aug 5, 2024

@mraineri Thanks for explaining the cause. What should I do to go forward asking the modeling question?

I've raised this for further review internally. You don't need to do anything directly, but since you're a DMTF member, you can see the discussions going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants