Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README should mention C++20 is needed to run tests #11

Closed
DrDub opened this issue Dec 5, 2023 · 1 comment · Fixed by #14
Closed

README should mention C++20 is needed to run tests #11

DrDub opened this issue Dec 5, 2023 · 1 comment · Fixed by #14

Comments

@DrDub
Copy link
Contributor

DrDub commented Dec 5, 2023

tests/CMakeLists.txt contains the following lines:

 # Required in order to test the std::span API as well
target_compile_features(tests PRIVATE cxx_std_20)

In particular, the tests do not compile with gcc-10.
@DNedic
Copy link
Owner

DNedic commented Dec 5, 2023

Good point actually, maybe it's better to introduce a CMake option to control whether the span API is tested or not.

@DNedic DNedic linked a pull request Dec 7, 2023 that will close this issue
Multi-threaded tests for more data structures #14
Merged
@DNedic DNedic closed this as completed in #14 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multi-threaded tests for more data structures DNedic/lockfree
2 participants
@DrDub @DNedic