Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler/runner version should be associated to executable #2536

Open
eldering opened this issue May 10, 2024 · 4 comments
Open

Compiler/runner version should be associated to executable #2536

eldering opened this issue May 10, 2024 · 4 comments

Comments

@eldering
Copy link
Member

Currently the compiler and runner version are part of the language table, but they are directly related to the compiler executable associated to the language, not the language itself. Thus, they should also be stored there.

@vmcj
Copy link
Member

vmcj commented May 10, 2024

I think I agree but I would prefer to keep the display on the language page (also).

@meisterT
Copy link
Member

I disagree.

A change in executable will not change the compiler/runner versions.

You need to change the chroot to change the versions instead. That's why the version table stores this info per langid and judgehostid. It then get's promoted to the language table when marked as canonical.

For more context, see #1241 (which I incidentally picked up a few days ago).

@eldering
Copy link
Member Author

A change in executable will not change the compiler/runner versions.

You need to change the chroot to change the versions instead. That's why the version table stores this info per langid and judgehostid. It then get's promoted to the language table when marked as canonical.

Well, that's also true. But if I change the executable for language C++ from c++-with-gcc to c++-with-clang, then I will definitely get a different compiler version too. So I think that this is more directly related to executable than language. I do agree though that we should show it at the language level.

@meisterT
Copy link
Member

meisterT commented May 11, 2024

For that my plan is to follow the spec (see https://ccs-specs.icpc.io/draft/contest_api#languages) and add compiler and runner fields in the language table. Then these will be passed to and can be used by the executable scripts as variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants