Deactivated contests still show up in API

[meisterT]

After we deactivate a contest, it is gone from dropdowns etc. in the web interface, but it is still available in the API. I would argue, it should also disappear in the API after deactivation.

[as6325400]

Can I try to handle it? Should I do it in the latest main branch? Thank you.

[Kevinjil]

Isn't this already implemented:

domjudge/webapp/src/Controller/API/ContestController.php

Line 140 in a75c73a

name: 'onlyActive',

[meisterT]

Good find Kevin! This has been added by @thijskh in 5fd1413 originally.

My personal opinion is that we should be consistent between UI and API and change the default to filter out deactivated contests.

WDYT?

[vmcj]

Good find Kevin! This has been added by @thijskh in 5fd1413 originally.

My personal opinion is that we should be consistent between UI and API and change the default to filter out deactivated contests.

WDYT?

So to add a flag alsoInactive and default only show active contests? Makes sense to me.