Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Node runtime of SST lambdas on old version of Node #1026

Open
karkir0003 opened this issue Oct 17, 2023 · 1 comment
Open

[BUG]: Node runtime of SST lambdas on old version of Node #1026

karkir0003 opened this issue Oct 17, 2023 · 1 comment
Assignees
Labels
backend backend tasks bug Something isn't working good first issue Good for newcomers

Comments

@karkir0003
Copy link
Member

Operating system

Windows, MacOS, Linux

Bug description

Problem
AWS has been sending emails to DLP saying that the node runtime of the API Gateway Lambda endpoints were running on Node 14 and that we are recommended to use Node js v18 as the runtime.

Solution
For the Api construct in SST (under AppStack.ts, set the runtime prop for the lambda (under default: {functions: {...}}) to be "nodejs18.x".
View these links from SST for more detail:

https://docs.sst.dev/constructs/Api - configure Function property within the Api construct
https://docs.sst.dev/constructs/Function#runtime - function runtime property
Testing Methodology

cd serverless && yarn sst dev - deploy api to dev stack (set resource name as dev) and then see if the nodejs runtime is version 18
Make sure to run an SST prod deploy when ready right about when you merge PR

Other considerations

Github action to automatically do sst deploy
Github action to validate if the AppStack.ts is configured correctly
dev vs. prod stack best practice (@dwu359 can you comment here)

Steps to reproduce

Go to AWS Management console and view the API Gateway Lambdas

@karkir0003 karkir0003 added the bug Something isn't working label Oct 17, 2023
@karkir0003 karkir0003 added the backend backend tasks label Oct 17, 2023
@github-actions
Copy link
Contributor

Hello @karkir0003! Thank you for submitting the Bug Request Form. We appreciate your contribution. 👋

We will look into it and provide a response as soon as possible.

To work on this bug request, you can follow these branch setup instructions:

  1. Checkout the main branch:
```
 git checkout nextjs
```
  1. Pull the latest changes from the remote main branch:
```
 git pull origin nextjs
```
  1. Create a new branch specific to this bug request using the issue number:
    git checkout -b bug-1026

Feel free to make the necessary changes in this branch and submit a pull request when you're ready.

Best regards,
Deep Learning Playground (DLP) Team

@karkir0003 karkir0003 added the good first issue Good for newcomers label Oct 17, 2023
@noah-iversen noah-iversen moved this from Backlog to Todo in DLP Project Board Feb 10, 2024
@karkir0003 karkir0003 moved this from Todo to In Progress in DLP Project Board Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend backend tasks bug Something isn't working good first issue Good for newcomers
Projects
Status: In Progress
Development

No branches or pull requests

2 participants